Skip to content

[Logger] Fixing code typo #15433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2021
Merged

[Logger] Fixing code typo #15433

merged 1 commit into from
Jun 15, 2021

Conversation

ThomasLandauer
Copy link
Contributor

No description provided.

@carsonbot carsonbot changed the title Fixing code typo [Logger] Fixing code typo Jun 15, 2021
@javiereguiluz javiereguiluz added this to the 5.3 milestone Jun 15, 2021
@javiereguiluz
Copy link
Member

Good catch, thanks Thomas.

@javiereguiluz javiereguiluz merged commit f3dc349 into symfony:5.3 Jun 15, 2021
@javiereguiluz
Copy link
Member

@Nyholm just asking: since these changes were made automatically ... could this be a bug in the code that generates the config builders ... or is it just a typo? Thanks!

@Nyholm
Copy link
Member

Nyholm commented Jun 15, 2021

Are you referring to the big PR where I added this typo?

If so, they are not automated. I was writing all those PR by hand. That why this error snuck in.

@javiereguiluz
Copy link
Member

Ah sorry! I thought there was some automation supervised manually. I'm sorry. And, again, a million thanks for your work updating all these docs 🙇

@Nyholm
Copy link
Member

Nyholm commented Jun 15, 2021

hehe.
No worries. I wish it was automated =)

@ThomasLandauer ThomasLandauer deleted the patch-3 branch June 15, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants